Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license to MIT #58

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Update license to MIT #58

merged 3 commits into from
Dec 22, 2023

Conversation

jwmbeenakker
Copy link
Contributor

@jwmbeenakker jwmbeenakker commented Dec 22, 2023

Proposed change

As discussed in #57, we want to change the license of ZOSPy to MIT, to better facilitate future (re-)use.

Type of change

Modified license to MIT

  • Example (a notebook demonstrating how to use ZOSPy for a specific application)
  • Bugfix (non-breaking change which fixes an issue)
  • New analysis (a wrapper around an OpticStudio analysis)
  • New feature (other than an analysis)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation (improvement of either the docstrings or the documentation website)

Additional information

not applicable

Related issues

closes #57

Checklist

  • I have followed the contribution guidelines
  • The code has been linted, formatted and tested locally using tox.
  • Local tests pass. Please fix any problems before opening a PR. If this is not possible, specify what doesn't work and why you can't fix it.
  • I added new tests for any features contributed, or updated existing tests.
  • I updated CHANGELOG.md with my changes (except for refactorings and changes in the documentation).

If you contributed an analysis:

  • I did not use AttrDicts for the analysis result data (please use dataclasses instead).

If you contributed an example:

  • I contributed my example as a Jupyter notebook.

CHANGELOG.md Outdated Show resolved Hide resolved
@crnh crnh merged commit 94aebd9 into main Dec 22, 2023
17 checks passed
@crnh crnh deleted the update-license branch December 22, 2023 09:59
@crnh
Copy link
Collaborator

crnh commented Dec 22, 2023

@jwmbeenakker this PR has successfully shown that autoclosing discussions from a PR is not a feature (autoclosing is only possible with issues), so #57 needs to be closed manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants