Remove small polygons from MOC basins #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this merge, setup_ocean_basins removes small polygons from MOC basins that are not useful for MOC computations.
xylar
force-pushed
the
moc_remove_small_polygons
branch
from
e270d0c to
b67c8be
Compare
Collaborator
Author
|
@milenaveneziani, this PR is just the parts of #78 that seem to clearly be useful. The disconnected bits of the Tasman Sea, that Amazon River, etc. are removed from the MOC basins so they are made up of only 1 (Atlantic, Indian, and 65N to 65S) or 2 (Pacific and Indo-pacific because of crossing 180 degrees longitude) large polygons. As we discussed in #78, we will explore another approach to finding the southern boundary that doesn't involve geometric features. This PR should be ready to test and merge. |
Collaborator
|
New MOCBasins look good to me: https://gist.github.com/milenaveneziani/841c216e44d24c5000752d18952cfd07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this merge, setup_ocean_basins removes small polygons
from MOC basins that are not useful for MOC computations.