-
Notifications
You must be signed in to change notification settings - Fork 25
Create southern boundary features for each MOC basin #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All geojson files produced by all features scripts except split_features.py and set_group_name.py now automatically set the groupName property of the feature collection to 'enterGroupName'. split_features.py produces individual feature files without a groupName property (as before). The new script set_group_name.py is used to set the groupName property of an existing feature file. The driver scripts setup_MOC_basins.py and setup_ocean_basins.py have been updated to produce fewer output files, each of which has its own group name.
|
@milenaveneziani, this is intended to address #69. It depends on #74, so should not be merged until that PR has been fulfilled. But it could be helpful to know if this is working the way you need it to before #74 gets merged (assuming that might take a little time). |
TestingI viewed I have not preformed any other testing of |
The new script, intersect_features.py can be used to find features that are the intersection of a set of features and the intersection of a set of intersection features.
These southern boundaries are computed using the new intersect_features.py script using MOC_34S and MOC_6S transect features.
2b1def9 to
2638736
Compare
|
@xylar: I created MOCSounthernBoundaries.geojson using this code, and then ran it through the mask creator tool. Built 714237 edges. |
|
@milenaveneziani, thanks for trying this out. I'll have to investigate further. I don't know much about how the mask creator works so it's hard for me to guess what the problem might be. Feel free to dig into the code yourself if you have the time and/or c++ expertise to do so. |
|
@milenaveneziani, I don't think the southern boundary as defined in this PR is what is needed for the MOC computation. Instead, I think what is actually needed is the following:
Both of these steps will require tools that are more sophisticated than the basic manipulation tools currently available in this repo. It is not yet clear to me if the tool should be included directly in |
|
#78 replaces this PR. |
This merge adds a script than can be use to intersect features. The features
in one file are intersected with the intersection of features in another file (which
will typically contain a single feature in any case).
This new script is used as part of the driver script to create MOC basins to
intersect two new transects,
MOC_34SandMOC_6S, with the MOC basinfeatures to create transects defining the southern boundary of each basin.