Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Jun 25, 2016

This PR adds a script, subdivide_transects.py, that is used
to subdivide transects (LineStrings) longer than a maximum length
(in degrees) into an integer number of subsegments. This is useful
because some tools (e.g. the MPAS MaskCreator) don't necessarily
follow the desired path between points that are far apart.

The maximum allowed segment length is supplied (in degrees) with
the -m flag at the command line.

This merge adds a script, subdivide_transects.py, that is used
to subivide transects (LineStrings) longer than a maximum length
(in degrees) into an integer number of subsegments. This is useful
because some tools (e.g. the MPAS MaskCreator) don't necessarily
follow the desired path between points that are far apart.
@xylar
Copy link
Collaborator Author

xylar commented Jun 25, 2016

@douglasjacobsen, this PR isn't a high priority but it also shouldn't be hard to test. I found that the MaskCreator makes a weird zig-zag between points that are spaced far apart (e.g. going 3 grid cells in one direction, 3 in another, etc.) rather than trying to follow as closely as possible the great circle path between points. Subdividing LineStrings seems to give me behavior that's at least close to what I want (though following straight lines in lat/lon space rather than great circles).

@pwolfram
Copy link
Contributor

@xylar, would you like me to review this PR? I'm thinking it should be merged before #52, which we are using partially as a clean-up type step. Would you concur?

But, based on the above comment it sounds like there may still be an issue with this PR, is that true?

@xylar
Copy link
Collaborator Author

xylar commented Sep 27, 2016

@pwolfram, I'm not yet sure this is useful to anyone but me, so let's leave it alone for now.

I'm not sure anyone else is trying to use the mask creator with transects, and I have already subdivided the transects used to open critical passages so they don't have this issue.

@xylar
Copy link
Collaborator Author

xylar commented Oct 23, 2016

An updated version of the script has been added to #78.

@xylar xylar closed this Oct 23, 2016
@xylar xylar deleted the subdivide_transects branch October 23, 2016 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants