This repository was archived by the owner on Oct 23, 2020. It is now read-only.
Add -i and -o flags to all mesh conversion calls in ocean test cases #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All calls to MpasMaskCreator.x, MpasMeshConverter.x and MpasCellCuller.x require -i and -o flags to be compatible with changes made to the syntax of these tools in the following pull requrest: MPAS-Dev/MPAS-Tools#149 Also, fixed a minor issue with the syntax in calls to the script init_step1.py in some global_ocean test cases
Contributor
Author
TestingI made sure the nightly regression tests are bit-for-bit identical to I don't plan on testing all 56 test cases because the changes in other test cases are exactly identical to those in tests covered by the nightly regression suite. |
Contributor
Author
|
It looks like we decided not to merge MPAS-Dev/MPAS-Tools#149 so I will close this PR, too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All calls to
MpasMaskCreator.x,MpasMeshConverter.xandMpasCellCuller.xrequire-iand-oflags to be compatible with changes made to the syntax of these tools in MPAS-Dev/MPAS-Tools#149. Also based on the same PR, the flag for inverse masking in the cell culler has been changed from-ito-v.This merge also fixes a minor issue with the syntax in calls to the script
init_step1.pyin someglobal_oceantest cases.