Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Nov 21, 2017

This prevents sea-ice thickness tasks from writing to the same file.

This prvents sea-ice thickness tasks from writing to the same
file.
@xylar xylar self-assigned this Nov 21, 2017
@xylar
Copy link
Collaborator Author

xylar commented Nov 21, 2017

Testing

I tested this on my laptop and confirmed that each task wrote its own remapped climatology. I will continue testing on other machines along with #271

@milenaveneziani
Copy link
Collaborator

@xylar, so, looking at the output I get from this and at what I was getting before, it seems to me that these changes only organize the climos better in the masked/, unmasked/ and remapped/ directories. It doesn't seem like before we were doing something wrong (I still see the 'hemisphere' part in the old file/directory names), but I don't know, maybe I am just confused.

Anyways, I like the re-organized structure better.

@xylar
Copy link
Collaborator Author

xylar commented Nov 21, 2017

@milenaveneziani, I appreciate you looking at this. The bug was introduced by #258. If you run the current develop, you will see the following remapped folders:

$ ls clim/mpas/remapped/
mld_oQU240v3_to_0.5x0.5degree          sss_oQU240v3_to_0.5x0.5degree
seaIceConc_oQU240v3_to_0.5x0.5degree   sst_oQU240v3_to_0.5x0.5degree
seaIceThick_oQU240v3_to_0.5x0.5degree

After this fix you should see:

$ ls clim/mpas/remapped/
...
seaIceConcNH_oQU240v3_to_0.5x0.5degree  seaIceThickNH_oQU240v3_to_0.5x0.5degree
seaIceConcSH_oQU240v3_to_0.5x0.5degree  seaIceThickSH_oQU240v3_to_0.5x0.5degree
...

The problem is with develop is that the two seaIceConc tasks are writing different seasons to the same file and the two seaIceThick tasks are writing the same data to the same file twice. Both of these could cause problems. For some reason my testing didn't expose this problem until today.

@milenaveneziani
Copy link
Collaborator

ah, I was comparing with results that predated #258 (by just one commit)! sorry about that.
When I compare with what I got from testing #258, I can see what you mean.

thanks.
I am using a merged branch, I will just push it now.

@milenaveneziani milenaveneziani merged commit 7735172 into MPAS-Dev:develop Nov 21, 2017
@xylar xylar deleted the fix_sea_ice_clim_remap branch November 21, 2017 20:09
@xylar
Copy link
Collaborator Author

xylar commented Nov 21, 2017

Thanks, @milenaveneziani.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants