Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Oct 7, 2017

There seems to be no such argument

There seems to be no such argument
@xylar xylar added the bug label Oct 7, 2017
@xylar xylar self-assigned this Oct 7, 2017
@xylar xylar requested a review from milenaveneziani October 7, 2017 23:11
@xylar
Copy link
Collaborator Author

xylar commented Oct 7, 2017

Before the is fix, I was getting warnings like the following when plotting climatology maps:

/home/xylar/miniconda2/envs/mpas_analysis/lib/python2.7/site-packages/matplotlib/contour.py:967: UserWarning: The following kwargs were not used by contour: 'spacing'

After this fix, the warnings go away. I believe this is a valid argument for colorbar but not for contourf and its inclusion in contourf may have been an error. Another possibility is that this was a previously supported argument that is no longer used, but I was not able to find evidence of this. In any case, the results are unchanged by removing this argument because it was already being ignored.

@xylar
Copy link
Collaborator Author

xylar commented Oct 7, 2017

@milenaveneziani, could you run a quick test and verify that I didn't break anything and that you don't see any warnings of the type listed above when you run? Thanks!

@milenaveneziani milenaveneziani merged commit d9162d0 into MPAS-Dev:develop Oct 8, 2017
@milenaveneziani
Copy link
Collaborator

nothing broken. and no warnings.

@xylar xylar deleted the fix_bad_contourf_arg branch October 8, 2017 06:46
@xylar
Copy link
Collaborator Author

xylar commented Oct 8, 2017

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants