[pull] master from facebook:master #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agerBinding.cpp Summary: Right now there are places in UIManagerBinding.cpp where native java exceptions will be thrown if calling JSI functions results in errors, such as: ```Trying to report error getPropertyAsObject: property '__fbBatchedBridge' is undefined, expected an Object Error: getPropertyAsObject: property '__fbBatchedBridge' is undefined, expected an Object ``` https://www.internalfb.com/intern/logview/details/facebook_android_javascripterrors/358181062b47b9561e60427bbb3816a9 In this diff I added LOG(ERROR) and checks because: 1, Throwing errors neither prevents the JSI errors nor handles them properly, checks prevent JSI errors from happening. 2, Errors are aggregated in Logview with other JSI errors as "Error: android_crash:com.facebook.react.devsupport.JSException:facebook::jni::throwNewJavaException" which keeps the SLA task open forever, checks can prevent JSI errors so they won't lead to exceptions, and LOG(ERROR) will make sure we have enough info for debugging. Changelog: [General][Changed] - Add checks and logs to for better error handling Reviewed By: JoshuaGross Differential Revision: D26885562 fbshipit-source-id: c0c1c057342e9efc0ff708188703f4332036e7a9
Summary: Changelog: [internal] Creates new function `RCTInstallNativeComponentRegistryBinding` which can be called during JS setup to register JS function `__nativeComponentRegistry__hasComponent`. Note: This diff doesn't call `RCTInstallNativeComponentRegistryBinding`. Reviewed By: shergin Differential Revision: D26946176 fbshipit-source-id: 0625b8dd6090bc9e08baa38ba60b9cbe48268184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )