[pull] master from facebook:master #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix ReadableArray annotations, because these methods throw ArrayIndexOutOfBoundsException instead of null if index is not found. ## Changelog [Android] [Changed] - fix ReadableArray null annotations. Possibly breaking change for Kotlin apps. Pull Request resolved: #30122 Test Plan: RNTester app builds and runs as expected, and show correct type in when used with Kotlin code. Reviewed By: JoshuaGross Differential Revision: D24164326 Pulled By: fkgozali fbshipit-source-id: 0c3f8fa9accbd32cc71c50befe9330e5201643f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )