Created a fix to persist screens in iOS #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sansyrox
requested review from
AnshG714,
Xtremilicious,
YashKumarVerma,
anikethsaha,
anku255,
chirag-singhal and
manyaagarwal
Member
|
@stealthanthrax There are some conflicts that occurred after merging #218. Can you please look into them? |
Member
Author
|
Sure @anku255 . |
Member
Author
|
@anku255 , have a look again? |
anku255
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fix will allow screens to persist even after app is killed from the app switcher.
Changelog
This bug was induced as we are writing same code in 2 diff places(RNTesterApp.ios.js and RNTesterApp.android.js) violating the DRY principle.
A followup PR for the abstraction layer is also in progress.
[IOS] [BUG] - Screen data now persisting after app kill
Test Plan
The app works on both the devices.