Some fixes.#2
Merged
MK-42 merged 6 commits intoMK-42:HighlightCratesNewfrom May 31, 2015
Merged
Conversation
I think this was why we had to add signals to each individual feature.
…selection changes.
This supports bolding/unbolding the playlist/crate when a track is added/removed.
Owner
|
I must have missed the SidebarModel completely... I tried adding the FontRole in TreeItemModel what didn't worked |
Owner
|
That is now blazing slow in SetLogFeature... My old aproach was fast there too. Should have tested before merge. Sorry for that. |
Merged
MK-42
pushed a commit
that referenced
this pull request
Dec 18, 2015
SoundManager should do this thing and this makes things clearer
MK-42
pushed a commit
that referenced
this pull request
Dec 18, 2015
I haven't checked all changes and all corner cases of moved/deleted files. At least scanning seems to be stable now.
MK-42
pushed a commit
that referenced
this pull request
Jan 18, 2018
Optimize formatting of string lists for SQL queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also found that the signals I asked you to add were only needed because the trackAdded signal got removed from LibraryFeature. Sorry about that!