-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set SimpleITK to 2.0.2, maintain list of packages only in requirements.txt #57
base: master
Are you sure you want to change the base?
Conversation
Let setup.py parse requirements.txt
Pull latest changes from MIC-DKFZ/HD-BET
Since HD-BET development, SimpleITK progressed a lot. The previous >= setting pulls 2.3.0 which does not install sucessfully with the rest of the requirements. This commit correctly sets SimpleITK==2.0.2 MIC-DKFZ@87226b1 (Not sure why it was set to >= afterward)
@@ -1,5 +1,4 @@ | |||
numpy>=1.14.5 | |||
torch>=0.4.0 | |||
scikit-image>=0.14.0 | |||
SimpleITK>=2.0.2 | |||
-e git+https://github.com/MIC-DKFZ/batchgenerators#egg=batchgenerators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was syntactically incorrect. We do not need it anyway because this function has been copied over:
Line 98 in ae16068
def resize_segmentation(segmentation, new_shape, order=3, cval=0): |
@@ -1,5 +1,4 @@ | |||
numpy>=1.14.5 | |||
torch>=0.4.0 | |||
scikit-image>=0.14.0 | |||
SimpleITK>=2.0.2 | |||
-e git+https://github.com/MIC-DKFZ/batchgenerators#egg=batchgenerators | |||
SimpleITK==2.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soft version specification no longer works because of progress of SimpleITK ever since. So I did hard specification.
Hi, please see my proposal in #56 in which we get rid of The hard specification that you have here can be done inside the Do you know if the maintainers of this project are interested in something like #56? |
I know I am not interested as 56 introduces complexity to a simple project and makes it hard for successors to maintain it. So it should be kept as is with my modification. |
Fair opinion :) The complexity automates a lot of the maintenance tasks. The project becomes easier to maintain. Publishing makes it possible to pip install the project directly. |
@tashrifbillah Thanks for the feedback! 🙏 As you mentioned, ensuring the project's maintainability over time is crucial. 🚀 Additionally, we should base the project's infrastructure and continuous integration on modern best practices. This will streamline the contribution process, testing, and distribution. I believe @ebrahimebrahim's proposal addresses this effectively. By leveraging a well-maintained and tested template, it adopts best practices already in use in hundreds of projects. This approach ensures that users can install and use the project seamlessly via Python wheels1 without needing to install development tools locally. These best practices are detailed in the development guides available at https://scientific-python.org/. It's also important to note that our current infrastructure, including your proposed changes, relies on Footnotes |
Hi, proposing this long overdue change--we should maintain the list of packages only in one place i.e.
requirements.txt
. This allows us to not touchsetup.py
.On the other hand, after 3 years, while trying to build HD-BET, we found that it does not build with soft version specification of
SimpleITK
. Hence, I have hardly specified2.0.2
. I notice that one of your commits already did it that way. But then somebody made it soft. I have just undone the latter.