Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if first element returns inf in _minimize_local_discrete #617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

This is to avoid if the first element returns inf, the last element is returned.

Note that for the application in find_localized_empirical_covariance() the whole thing implicitly assumes that the localization radii are ordered and increasing. And that once a localization radius leads to a singular covariance matrix all higher ones do too (reasonably).

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Note also that we do not use minimize_local_discrete anywhere else at the moment.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (681fa61) to head (fa715e8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   80.40%   80.44%   +0.03%     
==========================================
  Files          49       49              
  Lines        3082     3078       -4     
==========================================
- Hits         2478     2476       -2     
+ Misses        604      602       -2     
Flag Coverage Δ
unittests 80.44% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Closing again in favor of #493

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Okay leaving this here in case we decide to not merge #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in _minimize_local_discrete
1 participant