Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test data for precipitation #590

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sarasita
Copy link

Added monthly precipitation data for tests. The files were generated using cdo remapbil,r20x20 /net/atmos/data/cmip6-ng/pr/mon/g025/pr_mon_IPSL-CM6A-LR_historical_r1i1p1f1_g025.nc /home/scsarah/mesmer/tests/test-data/calibrate-coarse-grid/cmip6-ng/pr/mon/g025/pr_mon_IPSL-CM6A-LR_historical_r1i1p1f1_g025.nc

  • Closes #xxx
  • Tests added
  • Fully documented, including CHANGELOG.rst

…using cdo remapbil,r20x20 /net/atmos/data/cmip6-ng/pr/mon/g025/pr_mon_IPSL-CM6A-LR_historical_r1i1p1f1_g025.nc /home/scsarah/mesmer/tests/test-data/calibrate-coarse-grid/cmip6-ng/pr/mon/g025/pr_mon_IPSL-CM6A-LR_historical_r1i1p1f1_g025.nc
@veni-vidi-vici-dormivi
Copy link
Collaborator

Looks good, you could rename the folder and file start from pr to precip, that would make it a little clearer.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.43%. Comparing base (32f11c0) to head (b860f26).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files          49       49           
  Lines        3056     3056           
=======================================
  Hits         2397     2397           
  Misses        659      659           
Flag Coverage Δ
unittests 78.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarasita
Copy link
Author

Looks good, you could rename the folder and file start from pr to precip, that would make it a little clearer.

I would try and avoid renaming variables given 'pr' is the name consistent with the CMIP6 standard output variable names (https://pcmdi.llnl.gov/mips/cmip3/variableList.html) and the documentation of the Brunner et al input dataset (https://lukasbrunner.github.io/publications/Brunner2020.pdf)

@veni-vidi-vici-dormivi
Copy link
Collaborator

If you don't want to have to pull the precommit bot changes you can run pre-commit run --all-files locally 🤗

@mathause
Copy link
Member

Or install the pre-commit hooks (pre-commit install) which will then be automatically applied before committing (you may have to git add the changed files). Or manually run ruff check --fix .; black . before git add which will fix 99% of the issues addressed in the pre-commit hook (which is what I do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants