Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OpEquipmentRequirementType\EquipmentLevel codetype to EquipmentLevelType #74

Closed
gerardmoloneyetpartners opened this issue Jun 3, 2021 · 4 comments
Closed

Change OpEquipmentRequirementType\EquipmentLevel codetype to EquipmentLevelType #74

gerardmoloneyetpartners opened this issue Jun 3, 2021 · 4 comments

Comments

@gerardmoloneyetpartners
Copy link

The B2MML-Common.xsd defines the codetype for OpEquipmentRequirementType\EquipmentLevel codetype=HierarchyScopeType

This should be CodeType=EquipmentLevel

Additionally, the Sequence should relocate the EquipmentLevel to be immediately after the EquipmentID for easier understanding.

Existing XSD (lines 893 to 912) with the issue at Line 904
image

Proposed Fix - Relocate to line 898, and change codetype=EquipmentLevelType
image
@h28669
Copy link

h28669 commented Jun 14, 2021

I agree. It looks like wrong type in current schema definition.

@gerardmoloneyetpartners
Copy link
Author

Any movement on this guys?

@Dennis-Brandl
Copy link
Contributor

Yes, they need to be changed in the next version.

@Dennis-Brandl
Copy link
Contributor

Fixed with latest merge with main

Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Dennis-Brandl @h28669 @gerardmoloneyetpartners