Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysicalAsset Requirement #31

Closed
andreb1972 opened this issue May 14, 2019 · 5 comments
Closed

PhysicalAsset Requirement #31

andreb1972 opened this issue May 14, 2019 · 5 comments

Comments

@andreb1972
Copy link

The OpPhysicalAssetRequirementType and OpEquipmentRequirementType have an EquipmentLevel element which is of type HeirarchyScope. This appears to be incorrect, as there is already a HeirarchyScope within these types. Element level is usually contained within a HS, rather than being one. Is this intended?

<xsd:complexType name="OpEquipmentRequirementType">
         <xsd:sequence>  
                ...  
                <xsd:element name="EquipmentLevel" type="HierarchyScopeType" minOccurs="0"/>  
               ...  
         </xsd:sequence>  
</xsd:complexType>  
@Dennis-Brandl
Copy link
Contributor

This is intended. The hierarchy scope identifies where the exchanged information fits within the role-based equipment hierarchy. It defines the scope of the exchanged information, such as a site or area for which the information is relevant. The hierarchy scope identifies the associated instance in the role-based equipment hierarchy.
The EquipmentLevel in the OpPhysicalAssetRequirementType and OpEquipmentRequirementType define what the actual equipment is, in the hierarchy. so the first use is for the scope of the exchanged data (such as the exchanged information is scoped to a site), the second is what the asset actually is. we used the same type for both. Maybe a bad idea.

@Dennis-Brandl
Copy link
Contributor

I recommend not changing these uses, because they would be breaking changes. I will try and clarify in the documentation on the January 2020 Sprint.

@JoeDo
Copy link
Member

JoeDo commented Feb 3, 2020

Verified that the following documentation exists for HierarchyScopeType, defined in Common.xsd, in the January-2020-Sprint branch: The hierarchy scope identifies where the exchanged information fits within the role-based equipment hierarchy. It defines the scope of the exchanged information, such as a site or area for which the information is relevant. The hierarchy scope identifies the associated instance in the role-based equipment hierarchy.

I'll circle back and Close this issue after the changes have been merged into Master.

@Dennis-Brandl
Copy link
Contributor

This was a typo, changed the EquipmentLevel to the EquipmentLevelType and moved it up to after the Equipment element.

@gerardmoloneyetpartners
Copy link

for @andreb1972 and @andylee513 benefit, the typo was documented in issue #74 and fixed recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants