Fix: Resolve issues with numpy >= 2.3#2928
Merged
WhoBrokeTheBuild merged 1 commit intoMDSplus:alphafrom Jul 1, 2025
Merged
Conversation
Conditionally replace calls to tostring() with tobytes() Conditionally replace calls to fromstring() with frombuffer() Pass the numpy object directly to hashlib, instead of calling tostring()
WhoBrokeTheBuild
requested review from
heidthecamp,
joshStillerman,
mwinkel-dev and
santorofer
mwinkel-dev
approved these changes
Jun 30, 2025
Contributor
mwinkel-dev
left a comment
mwinkel-dev
left a comment
There was a problem hiding this comment.
These changes are straightforward and match the description, so approving this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditionally replace calls to tostring() with tobytes()
Conditionally replace calls to fromstring() with frombuffer()
Pass the numpy object directly to hashlib, instead of calling tostring()