python:Change options for MDSplus setup.py to install all of package contents#2618
python:Change options for MDSplus setup.py to install all of package contents#2618smithsp wants to merge 3 commits intoMDSplus:alphafrom
Conversation
mwinkel-dev
added
US Priority
branch/alpha
| %% | ||
| EOF_BEFORE | ||
| gcc -Iinclude -E -x c - << EOF_LIST |sed 's/#.*$//;/^$/d' | ||
| ${CC:-gcc} -Iinclude -E -x c - << EOF_LIST |sed 's/#.*$//;/^$/d' |
There was a problem hiding this comment.
Thankfully, this will be improved in the switch to CMake
|
|
||
| setup( | ||
| name='MDSplus', | ||
| version='7.139.40', |
There was a problem hiding this comment.
We'll need to pull the version either from a file or from the git tags
There was a problem hiding this comment.
I am open to suggestions. Preferably this can be something dynamic, but filled in when a release is made.
|
|
||
| def use_setuptools(): | ||
| from setuptools import setup | ||
| from setuptools import setup, find_namespace_packages |
There was a problem hiding this comment.
We can probably just delete this file entirely
|
@WhoBrokeTheBuild Thanks for looking this over. I am open to closing this for now, and waiting for the new build system to be released. For the conda build, I am creating this |
|
FYI... most of this was fixed in #2698. There is a slight improvement in |
|
OK. I will close it for now, and will check back later when I have time to see how things are done in the other branches. |
5 participants
I have implemented this change as a new setup.py file in the python directory, based off of the existing
omassetup.py file. Ignore the changes to the existing setup.py file.