Merged
Conversation
WhoBrokeTheBuild
force-pushed
the
cmake
branch
from
32dadb3 to
1a25d3a
Compare
WhoBrokeTheBuild
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
WhoBrokeTheBuild
force-pushed
the
cmake
branch
from
0cd066a to
ffdfb63
Compare
WhoBrokeTheBuild
force-pushed
the
cmake
branch
from
ffc27c8 to
302406e
Compare
WhoBrokeTheBuild
force-pushed
the
cmake
branch
from
cdbe036 to
ecd864a
Compare
WhoBrokeTheBuild
force-pushed
the
cmake
branch
from
ea25368 to
bcdeafb
Compare
WhoBrokeTheBuild
force-pushed
the
cmake
branch
from
801e8c4 to
a8ce496
Compare
WhoBrokeTheBuild
force-pushed
the
cmake
branch
3 times, most recently
from
60cf620 to
500f6a0
Compare
WhoBrokeTheBuild
force-pushed
the
cmake
branch
2 times, most recently
from
5c77c17 to
5414aa4
Compare
Include previously bootstrap-generated mdsconfig.h.in Add running of deploy/yylex.gen to CMake Wrap JavaMds in IF(ENABLE_JAVA) Fix link in MdsObjectsCppShr s/JavaMds/MdsIpShr/g WIP CMake Lowercase all of the CMake functions Handle BUILD_SHARED_LIBS=OFF Add HDF5 WIP CMake Refactoring and standardization Moved LIBXYZ variables into FindXYZ packages
Standardize all the FindXYZ scripts Fix the manifest warnings from fat_jar() Replace deploy/yylex.gen with explicit foreach loops Replace tdishr/yylex/TdiHash.gen with TdiHash.py Move *.y and *.l files out of yylex subdirectories
Make liblzma and git submodule update optional Refactor how files are generated, prefix gen- Add opcode number to opcodes.csv (No longer rely on the line number) Temporarily remove git submodule update Rename gen_ file. Refactor gen_compound. Add CMakeLists Fix broken opcodes.csv WIP Add missing SetEnvironmentForTests Add clangd's .cache/ to gitignore Comment out unused tests for LabView Add __attribute__((unused)) to help compile with newer compilers
* Finish reinstating bootstrap * fix type compatibility when compiling with Intel Fortran (ifort) * enable building with Intel Fortran * Add rpath functionality to remove dependence on LD_LIBRARY_PATH fix install prefix in rpath * Fix broken CMake 3.24 FindJNI on MacOS. Also allow JDK version setting on MacOS. * Fix use defined CACHE variable LIBXML2_DIR * fix allowing ENABLE_IDL=OFF to work when IDL is not on host * silence unused but set warning (+1 squashed commit) Squashed commits: [1c4dde515] TdiMath1.c scalars set but not used warning. Noop use inserted (because we don't yet have C23 and [[mabye-unused]] attribute.) * Darwin namespace collision avoided with ensureing _POSIX_C_SOURCE * testing fixes for MacOS (+1 squashed commit) Squashed commits: [6798c3ff4] fix name collision in UdpEventsTest on macos * change python setup to work with newer setuptools * improve FreeTDS/Sybase support * fix labview headers for newer macos compatibility * change sprintf to snprintf for gcc12 warnings * testing udp events in parallel leads to false error * testing on MacOS does not require unavailable librt * don't rely on dynamic linking in mitdevicesio * Missing links I think should be correct. * MacOS, prefer path python over system python * Allow fixed link of MacOS tdic instead of broken module TdiShr --------- Co-authored-by: Stephen Lane-Walsh <slwalsh@psfc.mit.edu>
Rewrite bootstrap in python Move gen-* scripts back to deploy Remove argparse in favor of constants Add more verbose output Replace os.walk with glob.glob in gen-messages Rename gen-* scripts to be more explicit Remove old CMake code that was intended to replace bootstrap Add CMake code to run bootstrap if it hasn't already been run
Set C/C++ Standard, Add ENABLE_LABVIEW Re-enable auto git submodule update, which may cause problems Add a first pass at running Java Tests Add mdsplus-api Java tests as well Add tests for tditest, small fixes / cleanup Now with C++ tests! Fixes for tests Fix py-task-do because it actually found an error! Fixes for python and java tests We now respect $PYTHON and try to use that version for scripts and $PyLib Turn $PYTHON into -DPYTHON, and have it default to $PYTHON Rehaul testing, work on Java Add mdsplus_add_test to wrap all calls to add_test This sets the environment variables and allows for defaults Java testing works, but isn't great Check for `FAILED` in the test output to catch the python failures Add main/subtree paths to test environment specifications
Move the sanitizers back to redhat, as `/bin/sh` on Debian/Ubuntu segfaults when used with `LD_PRELOAD=tsan.so` Add support for comments in the .opts files to document this ^ Improve the test summary in build.py when using a test regex
Rewrite {platform}_publish.py scripts to accept --release-dir, --publish-dir and --cert-dir instead of hardcoding /release, /publish, and /sign_keys
Update macosx-homebrew to use just "homebrew" as the --distname
Update macosx-macports to use just "macports" as the --distname
Update build.py to copy the tar of `install/usr/local/mdsplus` into the dist dir for macosx
Contributor
|
I have perused the 343 files changed by this work-in-progress PR and didn't see anything alarming. This high-level review confirmed that the changes are in the expected categories (Jenkins build scripts, CMake scripts, tests, environment variables, platforms, generation scripts, removing obsolete files, etcetera). With such a large PR, there could of course be some overlooked bugs. However, the risk of that is low because testing apparently shows that this CMake PR does build on many platforms and the resulting MDSplus does pass the automated test suite. Thus, if there are overlooked bugs, they are likely minor and thus should be easy to fix after this PR is eventually merged. |
Move over AdminList from alpha Jenkinsfile Move over options and triggers from alpha Jenkinsfile Move over commented-out sections that we will need from the alpha Jenkinsfile
WhoBrokeTheBuild
requested review from
mwinkel-dev and
santorofer
and removed request for
santorofer
mwinkel-dev
previously approved these changes
Oct 2, 2025
Contributor
mwinkel-dev
left a comment
mwinkel-dev
left a comment
There was a problem hiding this comment.
I have also reviewed the two commits made after my previous post. Those commits also look reasonable, so am approving this PR.
Add fake bootstrap as to not break existing workflows
mwinkel-dev
previously approved these changes
Oct 2, 2025
Contributor
mwinkel-dev
left a comment
mwinkel-dev
left a comment
There was a problem hiding this comment.
The last commit has three minor changes:
- Bootstrap script for backwards compatibility for people used to the old build scripts.
- Deletion of extraneous printf() statements.
- Removal of an obsolete file.
All looks good, so approving this PR.
mwinkel-dev
approved these changes
Oct 2, 2025
Contributor
mwinkel-dev
left a comment
mwinkel-dev
left a comment
There was a problem hiding this comment.
Most recent commit has a retry loop for downloading the Java library that implements SSH in Java programs (aka jsch.jar). Plus a minor formatting change in the CMakeLists.txt file.
The changes are straightforward, so approving this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.