Fix: matlab fails to compile code with 'py.' if no python present#2358
Closed
joshStillerman wants to merge 2 commits intoalphafrom
Closed
Fix: matlab fails to compile code with 'py.' if no python present#2358joshStillerman wants to merge 2 commits intoalphafrom
joshStillerman wants to merge 2 commits intoalphafrom
Conversation
MATLAB fails to compile any code which refers to 'py.' on machines lacking a python interpreter. Fix is to move all references to 'py.' to its own routines.
Contributor
|
hm well i assume you tested it .. with MATLAB2021a. looks ok.. One proposal I have though. do you think it makes sense to hide the private functions by moving them into ./matlab/private/ otherwise we may be bound to keep them "as users may relay on them". basically on would only want functions in ./matlab that the user is expected to invoke. |
Contributor
Author
|
Actually-
I am heading out to walk my dogs. I will be back by 12:30 and then
I have a meeting 1:45 - 3:00
-Josh
On 7/21/21 11:21 AM, Timo Schroeder wrote:
hm well i assume you tested it .. with MATLAB2021a. looks ok.. One
proposal I have though. do you think it makes sense to hide the
private functions by moving them into ./matlab/private/ otherwise we
may be bound to keep them "as users may relay on them". basically on
would only want functions in ./matlab that the user is expected to invoke.
the new files should go in there for sure.. maybe toe from/to and
NATIVE functions as they are called by mdsvalue no?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2358 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY5AZKKPMSW6EU7GUBQXA3TY3QWHANCNFSM5AYDKLJA>.
--
*Joshua Stillerman*
Research Engineer
MIT Plasma Science and Fusion Center
617.253.8176
***@***.*** ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix allows matlab mdsplus functions to work on computers that do not have a python interpreter.
Moves all references to 'py.' to functions in separate files.
closes #2357