Fix: Add validation for the user's selection of the frequencies for the ACQ 2106 435 SC device.#2305
Closed
santorofer wants to merge 2 commits intoMDSplus:alphafrom
Closed
Fix: Add validation for the user's selection of the frequencies for the ACQ 2106 435 SC device.#2305santorofer wants to merge 2 commits intoMDSplus:alphafrom
santorofer wants to merge 2 commits intoMDSplus:alphafrom
Conversation
Contributor
Author
|
I have done 3 tests for those 3 choices and all 3 tests have passed. |
Contributor
Author
|
This PR is closed because D-Tacq has changed sync_role() so that certain SR frequencies can be used. Therefore, the corresponding clock plan is automatically chosen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class ACQ2106_435SC has now a series of user's input validation for the allowed frequency choices that the acq2106 435SC has.
The allowed frequencies are:
40KHz (boot-time default)
20KHz
10KHz
Otherwise, an exception is raised.