Skip to content

Feature: cleanup Mdsip #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zack-vii merged 12 commits into from
Apr 21, 2021
Merged

Feature: cleanup Mdsip #2289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f089edd
update testing/memcheck/helgrind scripts
zack-vii Apr 20, 2021
4b8b8b0
tests: removed mdsip timeout from tests
zack-vii Apr 19, 2021
605c126
added fast_remte_write test to connectionsUintTest; optional
zack-vii Apr 19, 2021
1e9ebaa
EXPORT newMDSplusThreadStatic and destroyMDSplusThreadStatic
zack-vii Apr 19, 2021
d50525a
removed timeout from mdsip; source of dead-locks
zack-vii Apr 19, 2021
17684e0
ProcessMessage: cleanup
zack-vii Apr 19, 2021
e6e840c
removed unimplemented methods
zack-vii Apr 19, 2021
7a07d70
ProcessMessage: cleanup message
zack-vii Apr 19, 2021
ce46b84
python tests: added TestThread for easier threadded tests
zack-vii Apr 21, 2021
0cc9dde
reactivate TaskUnitTest
zack-vii Apr 21, 2021
b2ceb97
provide __traceback__ for python2
zack-vii Apr 21, 2021
0f3805b
valgrind.supp for fc32 python
zack-vii Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions conf/valgrind.supp/fc32.supp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@
fun:realloc
fun:_PyBytes_Resize
}
{
_PyObject_GC_Resize
Memcheck:Leak
match-leak-kinds: definite
fun:realloc
fun:_PyObject_GC_Resize
}
{
_PyLong_New
Memcheck:Leak
Expand Down
2 changes: 0 additions & 2 deletions deploy/packaging/debian/kernel_bin.amd64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
./usr/local/mdsplus/bin/mdsip-server-ssh
./usr/local/mdsplus/bin/mdsip_server
./usr/local/mdsplus/bin/mdsipd
./usr/local/mdsplus/bin/mdsiptest
./usr/local/mdsplus/bin/mdstcl
./usr/local/mdsplus/bin/remote_submit
./usr/local/mdsplus/bin/setevent
Expand All @@ -27,7 +26,6 @@
./usr/local/mdsplus/bin/unix_submit
./usr/local/mdsplus/bin/wfevent
./usr/local/mdsplus/lib/libMdsIpShr.so
./usr/local/mdsplus/lib/libMdsIpSrvShr.so
./usr/local/mdsplus/lib/libMdsIpTCP.so
./usr/local/mdsplus/lib/libMdsIpTCPV6.so
./usr/local/mdsplus/lib/libMdsIpUDT.so
Expand Down
2 changes: 0 additions & 2 deletions deploy/packaging/debian/kernel_bin.armhf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
./usr/local/mdsplus/bin/mdsip-server-ssh
./usr/local/mdsplus/bin/mdsip_server
./usr/local/mdsplus/bin/mdsipd
./usr/local/mdsplus/bin/mdsiptest
./usr/local/mdsplus/bin/mdstcl
./usr/local/mdsplus/bin/remote_submit
./usr/local/mdsplus/bin/setevent
Expand All @@ -27,7 +26,6 @@
./usr/local/mdsplus/bin/unix_submit
./usr/local/mdsplus/bin/wfevent
./usr/local/mdsplus/lib/libMdsIpShr.so
./usr/local/mdsplus/lib/libMdsIpSrvShr.so
./usr/local/mdsplus/lib/libMdsIpTCP.so
./usr/local/mdsplus/lib/libMdsIpTCPV6.so
./usr/local/mdsplus/lib/libMdsIpUDT.so
Expand Down
2 changes: 0 additions & 2 deletions deploy/packaging/debian/kernel_bin.i386
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
./usr/local/mdsplus/bin/mdsip-server-ssh
./usr/local/mdsplus/bin/mdsip_server
./usr/local/mdsplus/bin/mdsipd
./usr/local/mdsplus/bin/mdsiptest
./usr/local/mdsplus/bin/mdstcl
./usr/local/mdsplus/bin/remote_submit
./usr/local/mdsplus/bin/setevent
Expand All @@ -27,7 +26,6 @@
./usr/local/mdsplus/bin/unix_submit
./usr/local/mdsplus/bin/wfevent
./usr/local/mdsplus/lib/libMdsIpShr.so
./usr/local/mdsplus/lib/libMdsIpSrvShr.so
./usr/local/mdsplus/lib/libMdsIpTCP.so
./usr/local/mdsplus/lib/libMdsIpTCPV6.so
./usr/local/mdsplus/lib/libMdsIpUDT.so
Expand Down
2 changes: 0 additions & 2 deletions deploy/packaging/redhat/kernel_bin.i686
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
./usr/local/mdsplus/bin32/mdsip-server-ssh
./usr/local/mdsplus/bin32/mdsip_server
./usr/local/mdsplus/bin32/mdsipd
./usr/local/mdsplus/bin32/mdsiptest
./usr/local/mdsplus/bin32/mdstcl
./usr/local/mdsplus/bin32/remote_submit
./usr/local/mdsplus/bin32/setevent
Expand All @@ -29,7 +28,6 @@
./usr/local/mdsplus/bin32/wfevent
./usr/local/mdsplus/lib32
./usr/local/mdsplus/lib32/libMdsIpShr.so
./usr/local/mdsplus/lib32/libMdsIpSrvShr.so
./usr/local/mdsplus/lib32/libMdsIpTCP.so
./usr/local/mdsplus/lib32/libMdsIpTCPV6.so
./usr/local/mdsplus/lib32/libMdsIpUDT.so
Expand Down
2 changes: 0 additions & 2 deletions deploy/packaging/redhat/kernel_bin.x86_64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
./usr/local/mdsplus/bin64/mdsip-server-ssh
./usr/local/mdsplus/bin64/mdsip_server
./usr/local/mdsplus/bin64/mdsipd
./usr/local/mdsplus/bin64/mdsiptest
./usr/local/mdsplus/bin64/mdstcl
./usr/local/mdsplus/bin64/remote_submit
./usr/local/mdsplus/bin64/setevent
Expand All @@ -29,7 +28,6 @@
./usr/local/mdsplus/bin64/wfevent
./usr/local/mdsplus/lib64
./usr/local/mdsplus/lib64/libMdsIpShr.so
./usr/local/mdsplus/lib64/libMdsIpSrvShr.so
./usr/local/mdsplus/lib64/libMdsIpTCP.so
./usr/local/mdsplus/lib64/libMdsIpTCPV6.so
./usr/local/mdsplus/lib64/libMdsIpUDT.so
Expand Down
21 changes: 15 additions & 6 deletions mdsshr/MdsThreadStatic.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,17 @@ static inline void free_buffer(buffer_t *buf)
buf->free(buf->buffer);
free(buf);
}
static void free_mts(MDSplusThreadStatic_t *mts)

EXPORT MDSplusThreadStatic_t *newMDSplusThreadStatic()
{
MDSplusThreadStatic_t *mts =
(MDSplusThreadStatic_t *)malloc(sizeof(MDSplusThreadStatic_t));
mts->is_owned = TRUE;
mts->buffers = calloc(THREADSTATIC_SIZE, sizeof(buffer_t *));
return mts;
}

EXPORT void destroyMDSplusThreadStatic(MDSplusThreadStatic_t *mts)
{
if (mts->is_owned)
{
Expand All @@ -53,7 +63,8 @@ static void free_mts(MDSplusThreadStatic_t *mts)
}
free(mts);
}
static void init_mts_key() { pthread_key_create(&mts_key, (void *)free_mts); }

static void init_mts_key() { pthread_key_create(&mts_key, (void *)destroyMDSplusThreadStatic); }
EXPORT MDSplusThreadStatic_t *MDSplusThreadStatic(MDSplusThreadStatic_t *in)
{
// mts = MDSplusThreadStatic(NULL) : get current thread's mts
Expand All @@ -71,16 +82,14 @@ EXPORT MDSplusThreadStatic_t *MDSplusThreadStatic(MDSplusThreadStatic_t *in)
mts->buffers = in->buffers;
pthread_setspecific(mts_key, (void *)mts);
if (old_mts)
free_mts(old_mts);
destroyMDSplusThreadStatic(old_mts);
}
else
{
// create if NULL
if (!mts)
{
mts = (MDSplusThreadStatic_t *)malloc(sizeof(MDSplusThreadStatic_t));
mts->is_owned = TRUE;
mts->buffers = calloc(THREADSTATIC_SIZE, sizeof(buffer_t *));
mts = newMDSplusThreadStatic();
pthread_setspecific(mts_key, (void *)mts);
}
}
Expand Down
43 changes: 0 additions & 43 deletions mdstcpip/CloseConnection.c
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions mdstcpip/DisconnectFromMds.c
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions mdstcpip/FreeMessage.c
View file
Open in desktop

This file was deleted.

Loading