What if we did unpin sphinx? #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example docs for this PR rendered here |
|
Yeah this pin probably didn't need to exist -- 6.2.1 is the last version before 7.0 and sphinx-rtd-theme doesn't support 7.0 yet anyway. Thanks @IAlibay |
That's the next issue then, unless we can support new sphinx we're going to keep having the docutils pinning issue. |
|
Can we rely on sphinx-rtd-theme's docutils pinning? Also, I was wrong: sphinx 7.0 coming next release! 🎉 readthedocs/sphinx_rtd_theme#1463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.