fix: separate adapter wrappers for flexibility #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR separates concerns by extracting MIME type determination from HTML wrapping functionality. It splits the wrapHtmlWithAdapters function into two distinct functions: one for wrapping HTML content and a new getAdapterMimeType function for determining MIME types.
- Extracts MIME type logic from
wrapHtmlWithAdaptersinto a dedicatedgetAdapterMimeTypefunction - Simplifies
wrapHtmlWithAdaptersto only handle HTML wrapping and return a string instead of an object - Updates all tests and documentation to reflect the new separated functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdks/typescript/server/src/utils.ts | Adds getAdapterMimeType function and simplifies wrapHtmlWithAdapters to return string |
| sdks/typescript/server/src/index.ts | Updates imports and usage to call separated functions |
| sdks/typescript/server/src/tests/utils.test.ts | Adds tests for new getAdapterMimeType function and updates existing tests |
| sdks/typescript/server/src/tests/adapters/adapter-integration.test.ts | Updates tests to use simplified return values and adds integration tests for getAdapterMimeType |
| sdks/typescript/server/README.md | Updates documentation to show usage of both functions |
idosal
changed the title
Deploying mcp-ui with
|
| Latest commit: |
f9b2337
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9cc9a8b.mcp-ui.pages.dev |
| Branch Preview URL: | https://fix-appssdk.mcp-ui.pages.dev |
liady
approved these changes
Oct 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
…/v5.12.0-alpha.5...server/v5.12.0-alpha.6) (2025-10-13) ### Bug Fixes * separate adapter wrappers for flexibility ([#128](#128)) ([a636844](a636844))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.