-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uncommented multisession fixed.X0 #84
base: master
Are you sure you want to change the base?
Conversation
Hi Jan, Thanks for reaching out! Leaving the "fixing X0 across multisession" commented is voluntary. I understand that it looks like mistake, that why this part of the code was planned to be cleaned out completely in the next release (see the fix-MFX-multisession branch). I see you pushed two fixes and mentioned it then behaved as you expected. From what I see, you found a way to simulate a deterministic system with a fixed X0 across sessions, which is nice. However, be careful that this will work only for 1) simulating data and 2) deterministic systems. If the second point is not so important (although it should however be dealt with properly, eg. by throwing an error when trying to fix X0 on a stochastic system), the first one is more critical and can yield pernicious effects. In particular, the code implemented in your branch will not infer correctly on the value of X0, ie. your posterior will be wrong, even if everything seems to run correctly. If you want to get the "fixing X0" feature work also for inversion (ie with |
Hi Lionel, Thanks for your reply! You're right, I was only thinking about a deterministic system. I'm fitting data from a learning task where participants complete multiple blocks and there's no particular reason why X0 should differ between blocks, which is why I'm fixing it. Thanks also for pointing out that my 'fix' doesn't work for inverting a deterministic system; I wasn't aware of that. I think the reason I, perhaps naively, assumed it would work was because for the kind of data I'm fitting I've never implemented a variational Bayes algorithm but if you let me know what function to have a look at I can give it a go. |
Oh, you're absolutely right, sorry. Sleep deprivation is not helping me... |
That's great to hear! You're right, there was an issue with I've added that change, cleaned up my code, and wrote a couple of comments. I hope you're in bed already and only seeing this tomorrow when you've gotten enough sleep haha |
You might have accidentally left fixing X0 across sessions commented out when debugging? When I comment the two lines back in it works again.