Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 784 review four #521

Merged
merged 51 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
77d9cd9
continue of code review changes
czarte Jul 17, 2024
c974b66
test for panic in handle_retrieve_transactions
czarte Jul 19, 2024
c859541
fixing more comments from review
czarte Jul 23, 2024
3c93749
removing TODO
czarte Jul 23, 2024
0d50bbe
implementing review, added two new tests for ip_country
czarte Jul 24, 2024
15fa3ee
removing unnecesary country_code from node_descriptor
czarte Jul 26, 2024
4c2d57b
added cfg(test) and cfg(not(test)) for static ref COUNTRY_CODE_FINDER…
czarte Jul 26, 2024
75fb708
change country_code member of NodeRecordInner_0v1 to country_code_opt
czarte Jul 26, 2024
78cc0c2
simplifying tests in node_record.rs and neighborhood_database.rs
czarte Jul 26, 2024
fe8a9b4
resolving review comments
czarte Jul 30, 2024
bf10d81
final changes in gossip_acceptor from review
czarte Jul 31, 2024
bec7b8b
continue of implementing review comments
czarte Jul 31, 2024
1a74962
fix test return value
czarte Jul 31, 2024
f750f01
added ip_country to ci/all.sh
czarte Aug 7, 2024
002a311
cherry-pick from GH-784-fix-for-Vojta and implementing iterator for d…
czarte Aug 7, 2024
7cd7c0d
try to create test for fmt
czarte Aug 7, 2024
bc7a6cc
tests for print ip v4 and v6 vec[u8] in country_block_serde.rs
czarte Aug 8, 2024
69f79c5
ci for ip_country + resolved conflicts of clippy
czarte Aug 13, 2024
b0d8958
masq_lib dependencies solved
czarte Aug 14, 2024
f549131
dependency masq_lib for ip_country in node workspace
czarte Aug 14, 2024
ac3f186
remove commented out code + fix condition for non empty bit_queue
czarte Aug 14, 2024
e72ae56
formatting
czarte Aug 14, 2024
f5bb091
5 seconds for wait_for_log in requested_chain_meets_different_db_chai…
czarte Aug 15, 2024
2771e36
fixing impl for AGR in multinode tests
czarte Aug 15, 2024
715587e
formatting
czarte Aug 15, 2024
44db161
fix nonexistent NodeAddr in multinode tests for AGR
czarte Aug 16, 2024
d5307f3
change single match to if
czarte Aug 16, 2024
201cced
try to fix build in actions for MacOS
czarte Aug 19, 2024
e974e67
try to find out disk space on MacOS container in Actions
czarte Aug 19, 2024
f5f4afc
add diagnostics commands on failure
czarte Aug 19, 2024
859452b
check diskspace before ci/all.sh workflow runs
czarte Aug 19, 2024
6627715
diagnose mounted disks
czarte Aug 19, 2024
3ce6ac3
analyze /var/ diskspace
czarte Aug 19, 2024
b350db9
remove advanced diagnosticst for disk space
czarte Aug 20, 2024
8463d3d
switch macos to version 13
czarte Aug 20, 2024
7406b6f
diagnostics for /Users/runner/work/Node/Node/node/target/release
czarte Aug 21, 2024
9dd7982
fasten diagnostics
czarte Aug 21, 2024
e316e6c
fasten diagnostics fix
czarte Aug 21, 2024
c803f56
fasten diagnostics back
czarte Aug 21, 2024
b9d07b3
GH-784-review-two-state: fixes that could work on Actions, appeasing it
Aug 23, 2024
6b4e775
fixing review
czarte Aug 30, 2024
b7553ad
implementing CountryBlock count in generated rs file, and infrastructure
czarte Aug 30, 2024
68719e3
fixing ip_country tests
czarte Aug 30, 2024
48a3857
fix import of ip_country to multinode_integration_tests
czarte Sep 2, 2024
56d6010
formatting
czarte Sep 2, 2024
5b44e6b
fix the reference for COUNTRY_CODE_FINDER
czarte Sep 2, 2024
a977d4a
implemenitng initalization checker for COUNTRY_CODE_FINDER
czarte Sep 13, 2024
4259ddf
CountryCodeFinder initializer
czarte Sep 16, 2024
bbfa256
fixed comments from review
czarte Sep 16, 2024
bbb4350
removed custom PartialEq for NodeLocation
czarte Sep 17, 2024
0868ea6
get back with COUNTRY_CODE_FINDER
czarte Sep 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/ci-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
matrix:
target:
- { name: linux, os: ubuntu-22.04 }
- { name: macos, os: macos-12 }
- { name: macos, os: macos-14 }
- { name: windows, os: windows-2022 }

name: Build node on ${{ matrix.target.os }}
Expand Down Expand Up @@ -51,6 +51,11 @@ jobs:
with:
name: Node-${{ matrix.target.name }}
path: results
- name: diagnostics
if: failure()
run: |
echo "final disc diagnostics ------>"
df -h /Users/runner/work/Node/Node/node/target/release
deploy_to_s3:
needs: build
strategy:
Expand Down Expand Up @@ -100,4 +105,4 @@ jobs:
PATHS: "/Node*"
AWS_REGION: "us-west-2"
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
6 changes: 6 additions & 0 deletions ci/all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,10 @@ cd "$CI_DIR/../automap"
ci/all.sh "$PARENT_DIR"
echo "*** AUTOMAP TAIL ***"
echo "*********************************************************************************************************"
echo "*********************************************************************************************************"
echo "*** IP COUNTRY HEAD ***"
cd "$CI_DIR/../ip_country"
ci/all.sh "$PARENT_DIR"
echo "*** IP COUNTRY TAIL ***"
echo "*********************************************************************************************************"

1 change: 1 addition & 0 deletions ci/format.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,6 @@ format "$CI_DIR"/../dns_utility
format "$CI_DIR"/../masq
format "$CI_DIR"/../multinode_integration_tests
format "$CI_DIR"/../port_exposer
format "$CI_DIR"/../ip_country

exit $final_exit_code
Loading