GH-580: test for data_directory_from_context with opt dir and implementation … #248

bertllll · 2023-03-22T17:36:07Z

…in fn

node/src/node_configurator/mod.rs

…ode_configuraton_standard.rs

…alue'

bertllll

Take your time, no rush, address the comments and I'll be happy to see it again once done.

.vscode/launch.json

node/src/bootstrapper.rs

node/src/daemon/setup_reporter.rs

node/src/database/config_dumper.rs

node/src/node_configurator/node_configurator_standard.rs

…ew function node_chain_specific_directory for multinode tests

…, test for chain specific directories uncompleted but passing

This reverts commit c0f205a.

…_when_user_specifies_data_directory_without_chain_specific_directory

…rver_initializer_collected_params_senses_when_user_specifies_data_directory_without_chain_specific_directory

…ll path for user specified data-directory

…directory_within_integration test

…te tests

…unnerReal

… from test

…ry to fix node_creates_log_file_with_heading_integration - continue next

…passing when run from cmd line

…_when_user_specifies_data_directory_without_chain_specific_directory

…ectory and chain parameters to config

…ast_handler: removing unwanted piece of code, shared_schema: DATA_DIRECTORY_HELP, setup_reporter: fix test

…asq_lib to compute static constant DATA_DIRECTORY_DAEMON_HELP, fix broadcast_hadnler test

…d moving code thru directories and files

test for data_directory_from_context with opt dir and implementation …

3307e4b

…in fn

bertllll commented Mar 22, 2023

View reviewed changes

Vojtěch Parkán and others added 8 commits March 23, 2023 12:35

fixed naming and optimizing call for add_chain_specific_directories()

9894edf

add_chain_specific_directories to tests in bootstrapper.rs, mod.rs, n…

59fb959

…ode_configuraton_standard.rs

calculate_configured_setup returns None -> panicked at 'called on a v…

db1b485

…alue'

formatting

4c4f9af

git repair commit

ecfd9ec

cleaning misstake

ff95c7a

commit changes - move to laptop

bc1fbb3

fix tests failing on the chain specific data direcotry

9270242

czarte requested a review from utkarshg6 April 4, 2023 07:59

czarte self-assigned this Apr 4, 2023

bertllll commented Apr 4, 2023

View reviewed changes

czarte and others added 9 commits April 5, 2023 17:04

changes based on Berts review comments

ed5b782

formatting

1134be8

remove todo causing crash

27a29d7

half way to fix cleanup_after_deceased_clients_integration

2b261ab

failing on creating log file in node_logs_panic_integration

dac9533

change joins for add_chain_specific_directories fn

db221f5

remove unused import

c0f205a

add_chain_specific_directories moved to masq_lib::utils, introduced n…

9def8c3

…ew function node_chain_specific_directory for multinode tests

remove comments

0ab8322

czarte marked this pull request as ready for review May 3, 2023 09:15

czarte and others added 7 commits May 5, 2023 18:46

remove comments, replace joins wtih add_chain_specific_directories fn…

226567d

…, test for chain specific directories uncompleted but passing

Revert "remove unused import"

34591ca

This reverts commit c0f205a.

pull and resolve conflicts

f9133db

vec! with foreach for test server_initializer_collected_params_senses…

426fc7f

…_when_user_specifies_data_directory_without_chain_specific_directory

add more scenarios for test with custom data_directory_opt in test se…

0214c09

…rver_initializer_collected_params_senses_when_user_specifies_data_directory_without_chain_specific_directory

continue of solving Bert's comments, start of modifying UI to show fu…

13c586e

…ll path for user specified data-directory

try to retrieve chain-name from inner.values

54d4e40

czarte and others added 8 commits July 13, 2023 10:58

resolved review comments on ensure_data_directory_has_specific_chain_…

2ae1922

…directory_within_integration test

split of test calculate_setup_with_chain_specific_dir into two separa…

4385c89

…te tests

resolving review comments, renaming, optimization, fixing tests

53065b5

resolving review comments - mainly renaming

e4cdffa

Half way to get rid of DirsWrapper from go fn in DumpConfigRunnerReal

0daab9a

remove DirsWrapper from arguments to DumpConfigRunner for DumpConfigR…

575d76f

…unnerReal

fixed windows tests for determine_fundamentals

648b94e

renaming functions, removing TODOs and removing unnecesary attributes…

23caf03

… from test

dnwiebe approved these changes Jul 21, 2023

View reviewed changes

czarte added 7 commits July 21, 2023 17:09

resolving conflicts after merged master into GH-580

979ffbe

fixed node_chain_specific_data_directory and impl MASQRealNode plus t…

8dd6f5d

…ry to fix node_creates_log_file_with_heading_integration - continue next

fixed node_creates_log_file_with_heading_integration

0f5ea83

remove unused import and debug print, tests failing in ci/all.sh but …

d5a463f

…passing when run from cmd line

fix paths in tests for windows: setup_reporter

b23dfef

fix windows paths for test server_initializer_collected_params_senses…

3ccbbdb

…_when_user_specifies_data_directory_without_chain_specific_directory

fix setup_command and broadcast_handler tests: added missing data-dir…

ce2036f

…ectory and chain parameters to config

dnwiebe approved these changes Aug 2, 2023

View reviewed changes

czarte added 10 commits August 3, 2023 17:27

setup_command removign ropsten and correcting UiResponseValue, broadc…

3e13944

…ast_handler: removing unwanted piece of code, shared_schema: DATA_DIRECTORY_HELP, setup_reporter: fix test

correction of DATA_DIRECTORY_HELP

d575707

lazy_static for STANDARD_ARG_LIST in shared_schema

62986f8

separate help for --data-directory in Node, Config Dump and UI

432fed1

remove duplication of data-directory clap app argument, add dirs to m…

3cf0972

…asq_lib to compute static constant DATA_DIRECTORY_DAEMON_HELP, fix broadcast_hadnler test

move data-directory back to shared schema::shared_app::head

e3e12f2

remove typo misstake

63deecd

apply Dans comments on review 6, put code in the order, formatting an…

2c4fc68

…d moving code thru directories and files

remove unused import

7e89ede

resolve DATA_DIRECTORY_DAEMON_HELP for masq UI

14f9e5a

dnwiebe approved these changes Aug 17, 2023

View reviewed changes

czarte merged commit 97dfbad into master Aug 21, 2023

czarte deleted the GH-580 branch August 21, 2023 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-580: test for data_directory_from_context with opt dir and implementation … #248

GH-580: test for data_directory_from_context with opt dir and implementation … #248

bertllll commented Mar 22, 2023

bertllll left a comment

GH-580: test for data_directory_from_context with opt dir and implementation … #248

GH-580: test for data_directory_from_context with opt dir and implementation … #248

Conversation

bertllll commented Mar 22, 2023

bertllll left a comment

Choose a reason for hiding this comment