Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Add an option to not delete restrictions when fetching (default disabled) #1119

Closed
an0n981 opened this issue Jan 17, 2014 · 10 comments
Closed

Comments

@an0n981
Copy link
Contributor

an0n981 commented Jan 17, 2014

I just installed an app and fetched restrictions for it. Since only 2 people had submitted restrictions these were not considered reliable and all checks were removed. It would to have an option to cancel in such cases or maybe a general option to see what will be fetched and then have to confirm.

@wbedard
Copy link

wbedard commented Jan 17, 2014

+1 to displaying a summary of what permissions will be applied. This display would have an option to cancel the operation.

@Jimmy34742
Copy link
Contributor

If I fetch and my fetch request is "rejected" due to an unsatisfactory confidence interval, it should default to leaving the restrictions as they were instead of clearing them. Clearing them is the same behavior as a high confidence fetch that fetches all cleared restrictions. So the current method is ambiguous, requiring the user who notices to do some bookkeeping to verify what happened.

@jpeg729
Copy link
Contributor

jpeg729 commented Jan 20, 2014

If I'm reading the server code correctly, it doesn't communicate the confidence level to the app. It just reports non-restricted for any method whose votes don't meet the confidence interval. So if the app is in the database with only one submission, doing a fetch would result in nothing being restricted.

Maybe an app should only be available for fetching if at least all its categories meet the confidence interval. The app details view's fetch option could work differently, fetching the votes themselves to present the user a preview and let them choose.

Supposing one could add a comment per category on submission, the app could present for comment only the categories where at least one non-dangerous method was not restricted. So you'd be able to say why you allow the app to access the internet, or use the clipboard, or ... The comments should have a limited length.

Supposing then that the app details view could fetch the votes and comments and present it all for preview, the user could then read a few comments and choose which option to apply in each case. When the user has finished choosing, his choices could be transmitted back to the server to add weight to the votes.

@M66B
Copy link
Owner

M66B commented Jan 20, 2014

The crowd sourced restriction server will report No restrictions available" now, if none of the restrictions is reliable.
Is this a good enough solution for this issue?

@M66B
Copy link
Owner

M66B commented Jan 20, 2014

For reference: 610e829

@jpeg729
Copy link
Contributor

jpeg729 commented Jan 20, 2014

Supposing there are only three sets of votes, that only agree on one
category.
The result would be clearing everything except that category.

Maybe we need a minimum number of categories satisfying the CI. How about
reporting Nothing found if 5 or more categories don't satisfy the CI.

@Cerberus-tm
Copy link

What would make more sense to me would be if only those check boxes are changed for which there is a clear consensus, and the other boxes are left the way the user had them before fetching the restrictions, with a warning toast. Or is this impracticable?

@jpeg729
Copy link
Contributor

jpeg729 commented Jan 20, 2014

In other words, don't wipe first. That would work, wouldn't it?

@Cerberus-tm
Copy link

@jpeg729 Exactly!

P.S. Some kind of notification about which boxes had valid values in the database would be nice, but may not be worth the effort. Or at least a toast message "some tick boxes have been changed" or "no tick boxes have been changed".

@M66B
Copy link
Owner

M66B commented Feb 18, 2014

Duplicate or extension to #1319

@M66B M66B closed this as completed Feb 18, 2014
@M66B M66B reopened this Feb 23, 2014
@M66B M66B closed this as completed in 41a3d60 Feb 23, 2014
M66B pushed a commit that referenced this issue Feb 25, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants