Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented week recurrence and duplicate value handleing for expense… #77

Closed
wants to merge 1 commit into from

Conversation

kandoeniko
Copy link

…s and incomes

@@ -257,6 +262,14 @@ private int CalcMonthsInRange()
}

/// <summary>
/// Calculates the months in the range from the start date to the end date
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments here need to be updated.

@M-Zuber
Copy link
Owner

M-Zuber commented May 14, 2015

Thank you!
Overall it looks very nice, just some small details that need to be fixed.
I do still need to run some double checks before I merge

@M-Zuber M-Zuber mentioned this pull request May 14, 2015
@kandoeniko
Copy link
Author

Thanks for your feedback, I will correct the errors. It was my first
experience ever with github, I am still learning and I hope I didn't ruined
your project.

Have a nice day,
Eniko

2015-05-14 9:06 GMT+03:00 Mordechai Zuber [email protected]:

Thank you!
Overall it looks very nice, just some small details that need to be fixed.
I do still need to run some double checks before I merge


Reply to this email directly or view it on GitHub
#77 (comment).

@M-Zuber M-Zuber mentioned this pull request May 14, 2015
@M-Zuber
Copy link
Owner

M-Zuber commented May 20, 2015

@kandoeniko when you get a chance to fix the issues with this PR, please redo it onto the Development branch.
Thank you again, looking forwards to getting this code in.

@M-Zuber
Copy link
Owner

M-Zuber commented Jun 18, 2015

@kandoeniko any progress with this?

@M-Zuber M-Zuber closed this Jul 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants