Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model separation #14

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Model separation #14

wants to merge 27 commits into from

Conversation

LzLang
Copy link
Owner

@LzLang LzLang commented Apr 18, 2024

Currently the models in the BrAPI-Schema are nested.
We're working on a separation of those models into there own/separate models.
Currently we worked out the first version of a possible model separation.

We need to talk with Peter about the following things:

  • Separating the models even more
    • For example: nearly all models are using AdditionalInfo, currently we have an AdditionalInfo model in each other model
    • For those models we would like to create separate models and just use associations
  • Using the already existing models and using associations between those instead of creating copies of models in models
    • For example: In Observationvariable is the model Trait created and used but Trait is a model on it's own, therefore it would be more beneficial to use associations instead of copies of already existing models
  • Some models require a name instead of a id even when a id is an existing attribute
    • We would like to require the id instead of the name to ensure uniqueness
    • Also some models are using names/ids of other models but they just use an attribute/empty field instead of an association, we would like to change that.

Ur idea is by increasing the number of separate models, that we also increase the clarity and readability of the models.

@LzLang LzLang assigned LzLang and unassigned LzLang Apr 18, 2024
@LzLang
Copy link
Owner Author

LzLang commented Apr 19, 2024

The separation of models is basically done.

There a few things left to do:

  • Reviewing the models
  • Reviewing the associations
  • Reviewing the names in general
  • Talking with Peter about Coordinate
  • Reviewing IDs and unifying those
  • Substitute redundant attributes with associations
  • Cleaning up the models

All in all reviewing and cleaning up is left to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants