-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model separation #14
Open
LzLang
wants to merge
27
commits into
main
Choose a base branch
from
model_separation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Model separation #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Model separation
The separation of models is basically done. There a few things left to do:
All in all reviewing and cleaning up is left to do. |
fix coordinates model
No longer needed/empty
No longer needed/empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the models in the BrAPI-Schema are nested.
We're working on a separation of those models into there own/separate models.
Currently we worked out the first version of a possible model separation.
We need to talk with Peter about the following things:
AdditionalInfo
, currently we have anAdditionalInfo
model in each other modelObservationvariable
is the modelTrait
created and used butTrait
is a model on it's own, therefore it would be more beneficial to use associations instead of copies of already existing modelsUr idea is by increasing the number of separate models, that we also increase the clarity and readability of the models.