Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve .env.example #3004

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Improve .env.example #3004

merged 2 commits into from
Feb 14, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Feb 13, 2025

As per discussed in LycheeOrg/Lychee-Docker#216

@ildyria ildyria requested a review from a team as a code owner February 13, 2025 12:49
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (afabb49) to head (24c6ad0).
Report is 1 commits behind head on master.

Additional details and impacted files

.env.example Outdated Show resolved Hide resolved
Co-authored-by: Martin Stone <[email protected]>
@ildyria ildyria merged commit 5d80ff3 into master Feb 14, 2025
54 checks passed
@ildyria ildyria deleted the env.example branch February 14, 2025 07:40
DeMiro5001 added a commit to YunoHost-Apps/lychee_ynh that referenced this pull request Feb 15, 2025
Sync .env with upstream : LycheeOrg/Lychee#3004

>> Now : CACHE_DRIVER=redis
@DeMiro5001
Copy link

Hello,
I am maintaining the yunohost lychee package.
I am trying to update the package to add redis as CACHE_DRIVER.
So I updated the .env file according to the new example file :

CACHE_DRIVER=redis
REDIS_URL=redis://127.0.0.1:6379/__REDIS_DB__
REDIS_HOST=127.0.0.1
REDIS_PASSWORD=null
REDIS_PORT=6379
REDIS_CACHE_DB=__REDIS_DB__

The previous working version was :

CACHE_DRIVER=file
REDIS_HOST=127.0.0.1
REDIS_PASSWORD=null
REDIS_PORT=6379
REDIS_CACHE_DB=__REDIS_DB__

I am getting this error in the yunohost CI :

23915 INFO    DEBUG - > @php artisan optimize --clever --dont-confirm=assume-no
23915 INFO    DEBUG -
23915 INFO    DEBUG -    INFO  Clearing cached bootstrap files.
23915 INFO    DEBUG -
23915 INFO    DEBUG -   cache .......................................................... 2.02ms FAIL
23915 INFO    DEBUG -
23915 INFO    DEBUG - In PhpRedisConnector.php line 79:
23915 INFO    DEBUG -
23915 INFO    DEBUG -   Class "Redis" not found
23915 INFO    DEBUG -
23915 INFO    DEBUG -
23915 INFO    DEBUG - Script @php artisan optimize --clever --dont-confirm=assume-no handling the post-autoload-dump event returned with error code 1

Here is the full log

@ildyria
Copy link
Member Author

ildyria commented Feb 15, 2025

You need to install the php-redis extension (the one from Debian/Ubuntu/Alpine or whatever distribution you use)

@DeMiro5001
Copy link

I'm confused 😕. I thought I have added it to the manifest.
It's working now. Thanks a lot 🙏

@ildyria
Copy link
Member Author

ildyria commented Feb 15, 2025

@DeMiro5001 btw our website changed address: https://lycheeorg.dev (if you want to update your URLs in the readme.

@DeMiro5001
Copy link

Fixed. Will be available in the next PR, after 6.3.1 runs the Ci tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants