Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Displayed Times in Jobs page #2978

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

RustyPotato
Copy link
Contributor

Change from using substring to instead having JS parse the date.

Previously entries would've appeared as such:
firefox_ubKiz7fc2z
Take note of the last one, which is at 4:9, not how anyone would write 04:09 (or 4:09 AM even).

This was due to us parsing the string into numbers, and forgetting to place leading 0s as appropriate.

This has been fixed now, as seen in this preview:
firefox_m2sZoQKf95
It does so by letting the Javascript DateTime object do all the heavy lifting and work.

Furthermore, this change has a "feature" addition to it as well, as now datetimes are shown in the local datetime of the user instead of GMT, which will help keep it more readable. Furthermore respecting the users' locale, so Europeans will get DD MM YYYY and Americans MM DD YYYY, etc.
chrome_BYZnTxUHas
(Note the changing datetime formats based off Locale, as well as changing hours when GMT is converted to "local" timezone).

@RustyPotato RustyPotato requested a review from a team as a code owner February 1, 2025 03:10
@RustyPotato
Copy link
Contributor Author

RustyPotato commented Feb 1, 2025

I've also found similar datetime manipulation done here, but was unable to get my environment working such that I could test any changes there, so forewent attempting to change what I cannot (personally) test.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (dd2f220) to head (94b9856).
Report is 2 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit 43f36d1 into LycheeOrg:master Feb 1, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants