Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a small heartbeat endpoint #2958

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Add a small heartbeat endpoint #2958

merged 2 commits into from
Jan 26, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 26, 2025

No description provided.

@ildyria ildyria requested a review from a team as a code owner January 26, 2025 15:32
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 26, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (79fada4) to head (388a012).
Report is 2 commits behind head on master.

Additional details and impacted files

d7415
d7415 approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favour of these being simpler (usually plain text or json), but sure.

@ildyria
Copy link
Member Author

ildyria commented Jan 26, 2025

I'm generally in favour of these being simpler (usually plain text or json), but sure.

to be fair it is literally the one provided by Laravel 11, but ported to a Laravel 10 file structure.

@ildyria ildyria merged commit 9954ab4 into master Jan 26, 2025
50 checks passed
@ildyria ildyria deleted the up-endpoint branch January 26, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415