Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a feature flag to disable the content-type verification #2955

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Add a feature flag to disable the content-type verification #2955

merged 1 commit into from
Jan 26, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 25, 2025

The middleware was preventing requests to go through when testing from the /docs/api page.
This allows to do the requests.

@ildyria ildyria requested a review from a team as a code owner January 25, 2025 13:07
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 25, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.68%. Comparing base (79fada4) to head (a136e19).
Report is 1 commits behind head on master.

Additional details and impacted files

@ildyria ildyria force-pushed the add-flag-to-allow-use-of-api-doc branch from ea5977e to a136e19 Compare January 26, 2025 16:02
RonnieTaz
RonnieTaz reviewed Jan 26, 2025
View reviewed changes
Copy link

@RonnieTaz RonnieTaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks out well, I see no issue in either execution or documentation from the scramble document specification.

d7415
d7415 approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grumble

@ildyria ildyria merged commit 83fa1ab into master Jan 26, 2025
50 checks passed
@ildyria ildyria deleted the add-flag-to-allow-use-of-api-doc branch January 26, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnieTaz RonnieTaz RonnieTaz left review comments

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ildyria @d7415 @RonnieTaz