Allow to edit taken_at date

[ildyria]

by popular demand.

Fixes #2537

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (0bc5ab6) to head (72e4508).
Report is 1 commits behind head on master.

Additional details and impacted files

[ildyria]

After further thoughts, this is not the fully correct approach. There is one problem: the set taken_at date does not will not be considered for sorting etc. This somewhat defeats the purpose of the functionality.

I considered using taken_at_mod to store the original taken at date, but unfortunately changing the date twice would make this old non-existing date (null) gone.

Considering a third approach would require both taken_at_origin and a boolean is_exif_taken_at...

[ildyria]

After further thoughts, this is not the fully correct approach. There is one problem: the set taken_at date does not will not be considered for sorting etc. This somewhat defeats the purpose of the functionality.

I considered using taken_at_mod to store the original taken at date, but unfortunately changing the date twice would make this old non-existing date (null) gone.

Considering a third approach would require both taken_at_origin and a boolean is_exif_taken_at...

Fixed.

[sancsin]

Should we also allow changing the timezone? Right now we can only edit the time, what if there is also timezone information that user wants to edit?

[sancsin]

Looking good and user friendly! 🙂

[sancsin]

Instead for an InputText. Shall we have a dropdown instead with the following? I can look into implementing this in the near future, if you don't want to make this change right now.

UTC Offset Abbreviation Full Name
-12:00 (No common abbreviation) Uninhabited areas (Baker Island)
-11:00 (No common abbreviation) Niue Time
-10:00 HST Hawaii Standard Time
-09:00 AKST Alaska Standard Time
-08:00 PST Pacific Standard Time (US)
-07:00 MST Mountain Standard Time (US)
-06:00 CST (US) Central Standard Time (US)
-05:00 EST / ACT Eastern Standard Time (US) / Acre Time
-04:00 AMT Amazon Time
-03:30 NST Newfoundland Standard Time
-03:00 ADT Atlantic Daylight Time
-02:00 (No common abbreviation) South Georgia and Sandwich Islands
-01:00 (No common abbreviation) Azores Time
+00:00 UTC / GMT Coordinated Universal Time / Greenwich Mean Time
+01:00 CET / BST Central European Time / British Summer Time
+02:00 EET / CEST Eastern European Time / Central European Summer Time
+03:00 MSK / AST / EEST Moscow Standard Time / Arabian Standard Time / Eastern European Summer Time
+03:30 IRST Iran Standard Time
+04:00 GST / AZT Gulf Standard Time / Azerbaijan Time
+04:30 AFT Afghanistan Time
+05:00 PKT Pakistan Standard Time
+05:30 IST Indian Standard Time
+06:00 (No common abbreviation) Bhutan Time
+07:00 ICT Indochina Time
+08:00 CST (China) / HKT China Standard Time / Hong Kong Time
+09:00 JST / KST Japan Standard Time / Korea Standard Time
+09:30 ACST Australian Central Standard Time
+10:00 AEST Australian Eastern Standard Time
+11:00 (No common abbreviation) Solomon Islands Time
+12:00 NZST New Zealand Standard Time

[sancsin]

Looking really good now! :)

[sancsin]

Can be removed?

[ildyria]

already did xD

[ildyria]

Here: 72e4508