Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code coverage #2923

Merged
merged 23 commits into from
Jan 19, 2025
Merged

Improve code coverage #2923

merged 23 commits into from
Jan 19, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 17, 2025 •
edited
Loading

  • Add more tests...
  • A bunch of code ignore in difficult corners.
  • No changes of live code.

@ildyria ildyria marked this pull request as ready for review January 17, 2025 19:04
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (a836c2d) to head (e30772a).
Report is 1 commits behind head on master.

Additional details and impacted files

@ildyria ildyria requested a review from d7415 January 19, 2025 08:10
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 19, 2025
@ildyria ildyria requested a review from a team as a code owner January 19, 2025 10:50
d7415
d7415 approved these changes Jan 19, 2025
View reviewed changes
app/Metadata/Geodecoder.php Show resolved Hide resolved
app/Models/Extensions/HasRandomIDAndLegacyTimeBasedID.php Outdated Show resolved Hide resolved
app/Models/Extensions/SizeVariants.php Outdated Show resolved Hide resolved
tests/Feature_v2/Photo/PhotoEditTest.php Outdated Show resolved Hide resolved
@ildyria ildyria merged commit 90a154d into master Jan 19, 2025
52 checks passed
@ildyria ildyria deleted the coverage branch January 19, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415