Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration integrity check #2922

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Add configuration integrity check #2922

merged 2 commits into from
Jan 21, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 17, 2025 •
edited
Loading

Just checking that we are not missing values.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 17, 2025
@ildyria ildyria requested a review from d7415 January 17, 2025 08:01
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (47a8e6f) to head (73d2bc6).
Report is 12 commits behind head on master.

Additional details and impacted files

s-payyeri
s-payyeri approved these changes Jan 21, 2025
View reviewed changes
Copy link

@s-payyeri s-payyeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests to make sure that the ConfigIntegrity::SE_FIELDS is same as the keys present in the database. Looks good

@ildyria ildyria merged commit 92301cf into master Jan 21, 2025
52 checks passed
@ildyria ildyria deleted the config-check branch January 21, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

@s-payyeri s-payyeri s-payyeri approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ildyria @d7415 @s-payyeri