Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve route name clashes to enable cache generation #2869

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

kiancross
Copy link
Contributor

Clashing route names in routes/web_v2.php caused the error:

Unable to prepare route [X/Y] for serialization. Another route has already been assigned name [X].

when running php artisan route:cache.

This commit ensures that all routes have unique names, allowing the artisan command to successfully generate the route cache.

Clashing route names in `routes/web_v2.php` caused the error:

  Unable to prepare route [X/Y] for serialization. Another route has
  already been assigned name [X].

when running `php artisan route:cache`.

This commit ensures that all routes have unique names, allowing the
artisan command to successfully generate the route cache.
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (2b74431) to head (89a1495).
Report is 12 commits behind head on master.

Additional details and impacted files

@kiancross
Copy link
Contributor Author

I can fix the code style errors later today if you need me to before merging.

@ildyria
Copy link
Member

ildyria commented Jan 2, 2025

I can fix the code style errors later today if you need me to before merging.

I'll do it myself quickly ! :)

@ildyria ildyria merged commit 637e3f9 into LycheeOrg:master Jan 2, 2025
31 checks passed
@kiancross kiancross deleted the fix-routes-cache branch January 2, 2025 17:28
@ildyria ildyria added this to the 6.3 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants