Update README.md #2825
Merged
Update README.md #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
approved these changes
Dec 19, 2024
d7415
reviewed
Dec 19, 2024
README.md
Outdated
Comment on lines
42
to
44
| ### Docker deployment | ||
|
|
||
| Alternatively, an official Docker image can be found at [LycheeOrg/Lychee-Docker](https://github.com/LycheeOrg/Lychee-Docker) or on Docker Hub as [lycheeorg/lychee](https://hub.docker.com/r/lycheeorg/lychee). |
There was a problem hiding this comment.
This should probably be above File-based if we're recommending it.
There was a problem hiding this comment.
File-based has the disadvantage that many dependencies such as ffmpeg or the php version must fit. This catalog of dependencies does not exist with docker and the installation of the lychee docker variant requires 3 commandos. So maybe the way should point in that direction it is definitely the way I would recommend to install it today.
There was a problem hiding this comment.
Agreed, it just feels weird saying "We recommend using Docker, but first, here's how to do it a different way" :)
d7415
approved these changes
Dec 20, 2024
Co-authored-by: Martin Stone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
README.mdfile to enhance clarity, improve structure.Enhancements to the
README.md:masterandalphabranches to provide better context on the development process and encourage contributions.