Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate upload + add scroll remembering #2693

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 16, 2024

  • improve code style on ref()
  • use boolean globally defined in a store state for the most important modals (new album, upload)

See in particular:
https://github.com/LycheeOrg/Lychee/pull/2693/files#diff-5585be2db0c41adcd345e27400e1476598e1979d611d3030d032d049f64f12e4
https://github.com/LycheeOrg/Lychee/pull/2693/files#diff-4fdc99a20d4bdd62b978a193d29a30934d64bf6ceb26f010bd441b9e9ac167db
TODO later: migrate the other booleans (rename etc) to that store.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (15c8908) to head (6fc9b9c).
Report is 3 commits behind head on master.

Additional details and impacted files
---- 🚨 Try these New Features:

@ildyria ildyria added High Priority High priority issues Review: easy Easy review expected: probably just need a quick to go through. labels Nov 16, 2024
@ildyria ildyria added this to the 6.1.0 milestone Nov 16, 2024
@ildyria ildyria requested a review from d7415 November 16, 2024 02:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code is duplicate props.config.value === "1", maybe you could save the result above in a const

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But a const would not be updated on a save of the value as done with the watch :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

computed?

@tinohager
Copy link
Contributor

tinohager commented Nov 20, 2024

When does the pull-request flow into the alpha version of the docker container?

@ildyria ildyria changed the title Refactor toggling to avoid duplicate upload Fix duplicate upload + add scroll remembering Nov 20, 2024
@ildyria ildyria merged commit f6eb39e into master Nov 20, 2024
49 checks passed
@ildyria ildyria deleted the refactoring-toggling branch November 20, 2024 09:39
@ildyria
Copy link
Member Author

ildyria commented Nov 20, 2024

@tinohager about tonight it will be available on nightly/dev and alpha. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority High priority issues Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants