-
-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate upload + add scroll remembering #2693
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code is duplicate props.config.value === "1"
, maybe you could save the result above in a const
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But a const would not be updated on a save of the value as done with the watch :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
computed?
When does the pull-request flow into the alpha version of the docker container? |
@tinohager about tonight it will be available on |
ref()
See in particular:
https://github.com/LycheeOrg/Lychee/pull/2693/files#diff-5585be2db0c41adcd345e27400e1476598e1979d611d3030d032d049f64f12e4
https://github.com/LycheeOrg/Lychee/pull/2693/files#diff-4fdc99a20d4bdd62b978a193d29a30934d64bf6ceb26f010bd441b9e9ac167db
TODO later: migrate the other booleans (rename etc) to that store.