Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: restrict to v1.9 #345

Merged
merged 3 commits into from
Sep 19, 2023
Merged

RFC: restrict to v1.9 #345

merged 3 commits into from
Sep 19, 2023

Conversation

chrisbrahms
Copy link
Collaborator

@chrisbrahms chrisbrahms commented Sep 19, 2023 •
edited
Loading

For two main reasons:

  1. We currently run the test suite on 9 different combinations of Julia version and OS, which means a) we use lots of resources and b) the tests need to queue and checking a PR takes hours
  2. In light of test some basic precompilation #314 it's very useful to avoid constant precompilation, and v1.9 is much better at that

We also definitely can't support v1.6, so it makes sense to restrict to the latest supported version anyway.

@chrisbrahms
Copy link
Collaborator Author

Note to self: also need to change PR merging restrictions from v1.7/ubuntu to v1.9

jtravs
jtravs approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jtravs jtravs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - this is a good idea.

@chrisbrahms chrisbrahms merged commit 3b69ccf into LupoLab:master Sep 19, 2023
3 of 4 checks passed
@chrisbrahms chrisbrahms mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtravs jtravs jtravs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisbrahms @jtravs