Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make "HeJ" the default helium #332

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Conversation

chrisbrahms
Copy link
Collaborator

We already do this in prop_capillary because it's much more accurate in the DUV/VUV. Now that more people are using it who don't know about the differences, and especially because HiSol.jl will rely on the same data in the background, I think we should change this to make everything consistent and use the best data by default.

The sellmeier expansion from Börzsönyi can still be used to compare with :HeB instead.

@chrisbrahms chrisbrahms requested a review from jtravs August 2, 2023 19:00
Copy link
Contributor

@jtravs jtravs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with this change, this is fairly breaking. Anyone using :HeJ in their code will now get an error, unless I am mistaken. For backwards compatibility we should keep :HeJ as an alias for :He.

@chrisbrahms
Copy link
Collaborator Author

Fair enough, done

@chrisbrahms chrisbrahms merged commit e756eab into LupoLab:master Aug 4, 2023
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants