Fix overlap integrals for complex beams #279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This delightful little feature cost me several hours today: when
dot
ing two vectors containing complex values, the first is automatically conjugated:This PR removes additional manual conjugates to fix overlap integrals for beams which evaluate to complex-valued vectors (e.g. diverging Gaussian beams using
Fields.gauss_beam
). It also splits the integrals into real and imaginary parts to allow for potentially complex overlap integral values (ie a phase between the mode and the beam).