Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop void messages in serial discover #166

Merged
merged 6 commits into from
Oct 21, 2022
Merged

Drop void messages in serial discover #166

merged 6 commits into from
Oct 21, 2022

Conversation

JeromeGalan
Copy link
Member

No description provided.

nicolas-rabault
nicolas-rabault requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, you still have some cleaning to do.
Let's keep the key() thing.

@Rakadar33
Copy link
Contributor

I add the "keys" and I clean the WIP commit and it's OK

@JeromeGalan JeromeGalan merged commit 2fdc9d2 into rc_2.2.6 Oct 21, 2022
@JeromeGalan JeromeGalan deleted the fix/gate_discover branch October 21, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-rabault nicolas-rabault nicolas-rabault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeromeGalan @Rakadar33 @nicolas-rabault