Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve statistics handling #151

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Improve statistics handling #151

merged 3 commits into from
Aug 22, 2022

Conversation

fleborne
Copy link
Contributor

@fleborne fleborne commented Aug 4, 2022

I propose to:

  1. add the alias of the service among its statistics. This makes it easier to process a lot of statistics automatically.
  2. actually return the statistics in the luos_statistics getter. It is the expected behavior of a getter in my opinion.

@fleborne fleborne mentioned this pull request Aug 10, 2022
Merged
@JeromeGalan JeromeGalan changed the base branch from master to rc_2.2.4 August 22, 2022 14:03
nicolas-rabault
nicolas-rabault approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@nicolas-rabault nicolas-rabault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better, thank you.

@JeromeGalan JeromeGalan merged commit 2381f8d into Luos-io:rc_2.2.4 Aug 22, 2022
@fleborne fleborne deleted the feat/return-stats branch January 10, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-rabault nicolas-rabault nicolas-rabault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fleborne @nicolas-rabault @JeromeGalan