Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Remove (default) absolute path for schematics folder #51

Closed
lucom opened this issue Sep 10, 2014 · 2 comments
Closed

Enhancement: Remove (default) absolute path for schematics folder #51

lucom opened this issue Sep 10, 2014 · 2 comments
Labels

Comments

@lucom
Copy link

lucom commented Sep 10, 2014

Can you remove the value for the configured schematics folder if it is using the default folder?

I'm using some git-repository setup to distribute my customized MC clients to my "users". I "develop" and configure the clients on my DEV machine and commit the configuration and changed mods etc. to the repository. These changes can be fetched / pulled automatically and saved to an arbitrary location on the target systems (like Desktop\LMc.1.7.10 or ~/LMc.1.7.10).

The pre-configured path for the schematics folder most likely won't make any sense on the target system, which is why saving an absolute path with a specific notation (e.g. Windows or Linux) in the config would cause problems.

@Lunatrius Lunatrius added the bug label Sep 10, 2014
@Lunatrius
Copy link
Owner

Yeah, forgot to change that a while back. I'm not really sure what the best way to store the path is, I can normalize it as an absolute path or a relative path, but both may cause issues.

I'll see if there's a way to use ./schematics/ as the default path if the folder is inside the Minecraft root. Will have to work out something.

@lucom
Copy link
Author

lucom commented Sep 10, 2014

Maybe you could simply leave the path as an empty string in the configuration file as long as it points to the default path. The description could then explain that an empty string will simply point to $minecraftDir/schematics unless a specific path is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants