Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enderdragon particle crash #200

Closed
Syl2010 opened this issue Feb 15, 2017 · 17 comments
Closed

Enderdragon particle crash #200

Syl2010 opened this issue Feb 15, 2017 · 17 comments
Labels

Comments

@Syl2010
Copy link

Syl2010 commented Feb 15, 2017

I have a crash when the enderdragon create its end particle.

log : https://paste.ee/p/vZowg
fml client log : https://paste.ee/p/MX92d

MC 1.11.2
LunatriusCore-1.11-1.1.2.39-universal
Schematica-1.11-1.7.8.157-universal
Windows 10 64 bits
java 8 update 121

@Lunatrius
Copy link
Owner

How is that related to Schematica? Appears to be a vanilla (maybe Forge) bug.

@Syl2010
Copy link
Author

Syl2010 commented Feb 16, 2017

I have test with other mods, Minecraft crash only with schematica

@Lunatrius
Copy link
Owner

What do you do when the crash happens?

@Syl2010
Copy link
Author

Syl2010 commented Feb 16, 2017

I travel the portal or connect at the end, And after the dragon fire its first end ball, my game crash looped.

@Lunatrius Lunatrius added the bug label Feb 16, 2017
@Lunatrius
Copy link
Owner

Can you try setting remove erroring entities in the Forge config file to true and post the log after trying to reproduce the crash again?

@Syl2010
Copy link
Author

Syl2010 commented Feb 16, 2017

no crash, but the particles are invisible. rendering issue ?

log : https://paste.ee/p/CVBVK
fml client log : https://paste.ee/p/M2vEx

@Lunatrius
Copy link
Owner

That's impossible. I was considering a race condition, but if it persists it's something else. Can you remove Schematica only and try again?

@Syl2010
Copy link
Author

Syl2010 commented Feb 16, 2017

with the 'remove erroring entities' at true ?

@Lunatrius
Copy link
Owner

Lunatrius commented Feb 16, 2017

You can revert it back to false.

@Syl2010
Copy link
Author

Syl2010 commented Feb 16, 2017

no crash, and the particles are visible.

log : https://paste.ee/p/MVUqx
fml client log : https://paste.ee/p/TcqMQ

@Lunatrius
Copy link
Owner

Could you check if the same thing happens in single player under the same circumstances?

@Syl2010
Copy link
Author

Syl2010 commented Feb 16, 2017

All log i posted here are single player tests

@Lunatrius
Copy link
Owner

Could you upload the test world somewhere? Looks like you crash on world load, would make debugging a lot easier.

@Syl2010
Copy link
Author

Syl2010 commented Feb 16, 2017

link: https://www.dropbox.com/s/w00n1f7kkim34vi/schematica_end_particles_crash.zip?dl=1

With mods, config, options.txt and other logs folder.

@Lunatrius
Copy link
Owner

Thanks, I'll test it later today.

@Lunatrius
Copy link
Owner

This... is a weird bug. I can see what goes wrong, but not why. As a temporary work around you'll have to put the particle option in the setting to All when you'll want to use Schematica. I'll have to investigate why the world object is null inside of the calculateParticleLevel call...

    private int calculateParticleLevel(boolean p_190572_1_)
    {
        int i = this.mc.gameSettings.particleSetting;

        if (p_190572_1_ && i == 2 && this.world.rand.nextInt(10) == 0) // minimal, this.world == null
        {
            i = 1;
        }

        if (i == 1 && this.world.rand.nextInt(3) == 0) // decreased, this.world == null
        {
            i = 2;
        }

        return i; // all
    }

@Lunatrius
Copy link
Owner

Found the issue a lot quicker than expected (thanks to IntelliJ's awesome debugger). I missed a particle spawning override, resulting in vanilla code getting executed instead of my NOOP calls.

MattBDev pushed a commit to MattBDev/Schematica that referenced this issue Oct 22, 2021
MattBDev pushed a commit to MattBDev/Schematica that referenced this issue Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants