Print differences in supported extensions and features #1221
Conversation
|
CI gfxreconstruct build queued with queue ID 19802. |
|
CI gfxreconstruct build # 3060 running. |
| } | ||
| else | ||
| { | ||
| GFXRECON_LOG_WARNING("Feature storageBuffer16BitAccess requested at catpure is not supported by the replay device"); |
There was a problem hiding this comment.
"catpure" - I love this typo ;-)
I would prepare part of the string in advance and save quite a few conditionals here, would make code easier to read.
There was a problem hiding this comment.
Oops missed your comment. Will fix
|
CI gfxreconstruct build # 3060 passed. |
|
CI gfxreconstruct build queued with queue ID 20000. |
|
CI gfxreconstruct build # 3061 running. |
|
CI gfxreconstruct build # 3061 passed. |
|
CI gfxreconstruct build queued with queue ID 20278. |
|
CI gfxreconstruct build # 3062 running. |
|
|
||
| if (remove_unsupported) | ||
| { | ||
| const_cast<VkPhysicalDevice16BitStorageFeatures*>(currentNext)->storageBuffer16BitAccess = VK_FALSE; |
There was a problem hiding this comment.
If you want to save even more lines of code, you could do "... = !remove_unsupported;" here instead of the if clause :-)
|
CI gfxreconstruct build # 3062 passed. |
panos-lunarg
force-pushed
the
panos_760
branch
from
03f8bac
to
533ab1f
Compare
|
CI gfxreconstruct build queued with queue ID 21035. |
|
CI gfxreconstruct build # 3071 running. |
|
I realized that |
|
CI gfxreconstruct build # 3071 passed. |
|
CI gfxreconstruct build queued with queue ID 29575. |
|
CI gfxreconstruct build # 3127 running. |
|
CI gfxreconstruct build # 3127 passed. |
vkCreateDevice can fail with FEATURE_NOT_PRESENT error when features were requested during capture that are not present at the replay device. In this case the features that are not supported will be printed as a warning message.
panos-lunarg
force-pushed
the
panos_760
branch
from
33db6dc
to
8514d98
Compare
|
CI gfxreconstruct build queued with queue ID 30087. |
|
CI gfxreconstruct build # 3132 running. |
|
CI gfxreconstruct build # 3132 passed. |
In case vkCreateInstance and vkCreateDevice fail at replay time because of an EXTENSION_NOT_PRESENT error, should now print which were the extensions that were not supported on the replay gpu and triggered the error.
Similarly features requested with vkCreateDevice during capture will be compared with what the replay device offers and print a warning for each feature not supported.