Allow ags.lib/agsd.lib for win32 replayer/optimizer #1216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 15429. |
|
CI gfxreconstruct build # 3040 running. |
|
CI gfxreconstruct build # 3040 passed. |
|
This change is not currently required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We may need to use AGS functions, such as agsDriverExtensionsDX12_PushMarker, through statically linking to ags.lib or agsd.lib for replay project or optimize project. Currently the required libs are included for x64 builds of the replay project and the optimize project. The AGS libs are missing for win32 builds.
Solution
Adjust related AGS related flags in CMakeLists files.
Result
ags.lib/agsd.lib show up in the link input list for win32 builds.