apidump: Use correct aliased types #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI VulkanTools build queued with queue ID 17179. |
|
CI VulkanTools build # 2584 running. |
|
CI VulkanTools build # 2584 passed. |
VkAccelerationStructureTypeNV and VkBuildAccelerationStructureFlagsNV are aliased types which are explicitly used by the VK_NV_ray_tracing extension. Because apidump didn't know how to keep track of aliases and then fixup uses of aliased types into the real type, those two types had hand written typedefs. This commit is able to remove the hardcoding as well are removes both redundant code (self.trackedTypes) and dead code (str_VkStructureTypeToEnum).
charles-lunarg
force-pushed
the
api_dump_use_correct_aliased_type
branch
from
8ca360a
to
2e442f8
Compare
charles-lunarg
requested review from
TonyBarbour
and removed request for
davidlunarg
|
Just tested it locally, but this fixes the issue causing VK_NV_cooperative_matrix to not generate correctly. |
|
CI VulkanTools build queued with queue ID 24000. |
|
CI VulkanTools build # 2625 running. |
|
CI VulkanTools build # 2625 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VkAccelerationStructureTypeNV and VkBuildAccelerationStructureFlagsNV are aliased types which are explicitly used by the VK_NV_ray_tracing extension. Because apidump didn't know how to keep track of aliases and then fixup uses of aliased types into the real type, those two types had hand written typedefs. This commit is able to remove the hardcoding as well are removes both redundant code (self.trackedTypes) and dead code (str_VkStructureTypeToEnum).
Fixes #977